structured logging for node + WebAssembly bindings #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
commented
Nov 8, 2024
insipx
commented
Nov 8, 2024
| @@ -184,17 +185,17 @@ impl InboxOwner for Wallet { | |||
| async fn main() -> color_eyre::eyre::Result<()> { | |||
| color_eyre::install()?; | |||
| let cli = Cli::parse(); | |||
| let crate_name = env!("CARGO_PKG_NAME"); | |||
| let filter = EnvFilter::builder().parse(format!("{crate_name}=INFO,xmtp_mls=INFO"))?; | |||
There was a problem hiding this comment.
I used the CLI to test the new filtering used
insipx
commented
Nov 8, 2024
| tracing::info!( | ||
| inbox_id = self.client.inbox_id(), |
There was a problem hiding this comment.
many of these K/Vs are the same, eventually can make them into a macro
insipx
force-pushed
the
insipx/structured-logging-node
branch
from
84b0514 to
e6cb4ca
Compare
nplasterer
approved these changes
Nov 8, 2024
insipx
force-pushed
the
insipx/structured-logging-node
branch
2 times, most recently
from
13b3643 to
23fd444
Compare
insipx
force-pushed
the
insipx/structured-logging-node
branch
from
23fd444 to
eddaffe
Compare
insipx
changed the title
insipx
force-pushed
the
insipx/structured-logging-node
branch
2 times, most recently
from
0a47a3d to
11d058e
Compare
insipx
force-pushed
the
insipx/structured-logging-node
branch
2 times, most recently
from
3ca1085 to
689d78b
Compare
insipx
force-pushed
the
insipx/structured-logging-node
branch
from
689d78b to
80b8878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows enabling structured logging for Node and WASM. Namely, enabling structured logging emits JSON logs. These logs may be filtered by additional K/V pairs added mostly during the
syncprocess. This allows precise filtering of the sync process for chosen values.K/V Pairs:
@rygine this adds some options to the Node/JS Sdk, client creation methods, would appreciate your review